fix: parseUnits rounding for long fractional values#4857
Open
nikhilkumar1612 wants to merge 1 commit into
Open
fix: parseUnits rounding for long fractional values#4857nikhilkumar1612 wants to merge 1 commit into
nikhilkumar1612 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2f256d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@nikhilkumar1612 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4855
This PR fixes
parseUnitsrounding for long fractional values near half boundaries.Previously,
parseUnitsusedNumber(...)andMath.round(...)when the fractional part exceeded the requested decimal precision. For long decimal strings, JavaScript floating-point conversion can round values like.49999999999999999999to0.5, causingparseUnitsto round up incorrectly.This changes rounding to stay in decimal string/
BigIntspace by checking the first discarded fractional digit and carrying manually.