Implement overheal consumption effects (melee & fire spells)

[Gorzoid]

(fire isn't specifically overheal consumption but decided to fix both in one PR)

• Adds min hit of 5 to melee if overhealed by atleast 5hp (from wording I am assuming it wont consume less than 5)
• Adds flat damage equal to double of 6% of max hp or max damage without killing (whichever is smaller)

Not intending to accumulate hp consumed here, just assuming the player is somehow healing that hp before next attack. Anything else would be confusing. Also not sure how this plays into multihit attacks, I would assume damage is dealt once per attack but minhit is increased for all hits.

[orlp]

I think assuming it will be consumed every time is gonna inflate people's setups a lot. Needs some kind of configuration/toggle in my opinion.

[Gorzoid]

I think assuming it will be consumed every time is gonna inflate people's setups a lot. Needs some kind of configuration/toggle in my opinion.

Yes true, although same can be said for ruby bolt dps. People selecting these relics should take that into account and understand this is instantaneous dps. Its already disabled by default for melee since requires inputting overheal hp. For fire builds, you basically have 2 options:

• Assume your camping 1hp most of the time, so set hp to 1 which disables damage boost
• Assume you heal on average N hp each attack, so keep hp at N+1

I think auto-calculating average heal might be cool, and should be possible, but shouldn't block addition of this effect into calc.