Update ParallelSimulation.luau

[workframes]

Summary by CodeRabbit

• Bug Fixes
  • Improved how simulation event modules are detected and loaded, making module registration more reliable.
  • Tightened validation so only valid module instances are accepted during setup, reducing the chance of unexpected runtime issues.

[coderabbitai]

📝 Walkthrough

Walkthrough

ParallelSimulation now stores required FastCastEvents values in its cache and only requires FastCastEventsModule when the value is an Instance ModuleScript. The exported module value is unchanged.

Changes

FastCast event typing and registration guard

Layer / File(s)	Summary
Event cache typing and guard src/ParallelSimulation.luau	The cached FastCast events table now stores required FastCastEvents values, Register only requires FastCastEventsModule when the value is an Instance ModuleScript, and the return statement is unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• weenachuangkud

Poem

(_/)
( •_•) The bunny hops through typed-up light,
/ >🍃 FastCast events now fit just right.
ModuleScript checks keep burrows neat,
and ParallelSimulation lands on its feet. 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is directly related to the changes and clearly identifies the updated file, though it is broad rather than specific.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/ParallelSimulation.luau`:
- Line 488: The assignment in the FastCastEvents registration path is too narrow
because it only handles ModuleScript values and falls back to nil for
already-required tables. Update the logic around casts_FastCastEvents[id] in
ParallelSimulation so it preserves an existing FastCastEvents table from
cast.RayInfo.FastCastEventsModule instead of clearing it, while still requiring
ModuleScript instances when needed. Also align the TypeDefinitions.luau contract
for FastCastEventsModule with the widened runtime shape so the type system
reflects both supported forms.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ff04281-87e3-4189-8299-792c45bbd4a0

📥 Commits

Reviewing files that changed from the base of the PR and between 2875e28 and 127f49a.

📒 Files selected for processing (1)

• src/ParallelSimulation.luau

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Preserve pre-required FastCastEvents tables here.

This branch still writes nil for any non-ModuleScript value. If cast.RayInfo.FastCastEventsModule is already the required FastCastEvents table, all module callbacks stay disabled because casts_FastCastEvents[id] never gets populated. The upstream type in src/TypeDefinitions.luau:422-434 also still says this field is ModuleScript, so the widened runtime contract is currently invisible to the type system.

Suggested fix

  local eventModule = cast.RayInfo.FastCastEventsModule
- casts_FastCastEvents[id] = (typeof(eventModule) == "Instance" and eventModule:IsA("ModuleScript")) and require(eventModule) or nil
+ casts_FastCastEvents[id] =
+   if typeof(eventModule) == "Instance" and eventModule:IsA("ModuleScript") then
+     require(eventModule)
+   else
+     eventModule

As per coding guidelines, **/*.luau: Use Luau static typing throughout the codebase.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	casts_FastCastEvents[id] = (typeof(eventModule) == "Instance" and eventModule:IsA("ModuleScript")) and require(eventModule) or nil
	local eventModule = cast.RayInfo.FastCastEventsModule
	casts_FastCastEvents[id] =
	if typeof(eventModule) == "Instance" and eventModule:IsA("ModuleScript") then
	require(eventModule)
	else
	eventModule

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ParallelSimulation.luau` at line 488, The assignment in the
FastCastEvents registration path is too narrow because it only handles
ModuleScript values and falls back to nil for already-required tables. Update
the logic around casts_FastCastEvents[id] in ParallelSimulation so it preserves
an existing FastCastEvents table from cast.RayInfo.FastCastEventsModule instead
of clearing it, while still requiring ModuleScript instances when needed. Also
align the TypeDefinitions.luau contract for FastCastEventsModule with the
widened runtime shape so the type system reflects both supported forms.

Source: Coding guidelines