Skip to content

Update engines field to node 22 or below #236

Open
C4illin wants to merge 1 commit intowebosbrew:mainfrom
C4illin:update-engines-to-node-22-or-below
Open

Update engines field to node 22 or below #236
C4illin wants to merge 1 commit intowebosbrew:mainfrom
C4illin:update-engines-to-node-22-or-below

Conversation

@C4illin
Copy link
Copy Markdown

@C4illin C4illin commented Apr 5, 2026

Took me a while to figure out that it doesn't work on node 24, so it might help somebody in the future

@kitsuned
Copy link
Copy Markdown
Member

kitsuned commented Apr 5, 2026

can you explain why Node 24 is broken? right now it just adds a cap without context.

if Node 24 genuinely "not working", it's probably a tooling/dependency issue. in that case it would be better to update toolchain instead of restricting engine.

@C4illin
Copy link
Copy Markdown
Author

C4illin commented Apr 6, 2026

Yes of course! The error is util.isRegExp is not a function which is used by clean-css which is a dependency of enyo-dev, which doesn't have any updates available. Tested with an overrides and it works.

But there is also an other issue on node24 which I haven't investigated further ares-install ERR! uncaughtException TypeError: isDate is not a function.

Just thought to open this up when I had the codebase open, you can close the PR :)

@throwaway96
Copy link
Copy Markdown
Member

Of course it's an LG thing...

@C4illin
Copy link
Copy Markdown
Author

C4illin commented Apr 21, 2026

EOL of node 22 is April 2027 so locking a node 22 version isn't really that bad a thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants