fix(service): properly wrap luna errors in asyncCall#222
Open
kitsuned wants to merge 1 commit intowebosbrew:mainfrom
Open
fix(service): properly wrap luna errors in asyncCall#222kitsuned wants to merge 1 commit intowebosbrew:mainfrom
kitsuned wants to merge 1 commit intowebosbrew:mainfrom
Conversation
Member
|
This sounds extremely familiar... I thought I fixed (something exactly like?) this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if luna callee returns an error (
returnValueisfalse),asyncCallthrows the raw payload object instead of an Error.further down the call stack,
tryRespondcatches this value and callsassertNodeError.assertNodeErrorchecks whether the argument's prototype isErrorand throws a new error if a raw payload is passed.as a result, this leads to an unhandled promise rejection. HBC's Luna service does not send a response to client, which causes request calls to hang indefinitely.
this PR fixes promise rejection.