Fix stdout/stderr streaming to safely handle multibyte UTF-8 characters across chunks - #20
Conversation
…rs across chunks This PR replaces `String::from_utf8_lossy` in the `CommandExecutor::execute` output streaming loop with a buffering mechanism. This ensures that multibyte characters (like emojis or accents) aren't garbled into replacement characters when they happen to be split across two network/pipe read chunks, improving reliability and UX for terminal output. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR replaces
String::from_utf8_lossyin theCommandExecutor::executeoutput streaming loop with a buffering mechanism. This ensures that multibyte characters (like emojis or accents) aren't garbled into replacement characters when they happen to be split across two network/pipe read chunks, improving reliability and UX for terminal output.No documentation or config files were altered. Tests are completely passing. Pre-commit passes. No temporary files were added or committed.
PR created automatically by Jules for task 12694107265540543117 started by @insign