Skip to content

Fix NextFontIssue IssueStage: CodeGen → Resolve#92588

Merged
sokra merged 1 commit intocanaryfrom
sokra/NextFontIssue-issue-stage
Apr 10, 2026
Merged

Fix NextFontIssue IssueStage: CodeGen → Resolve#92588
sokra merged 1 commit intocanaryfrom
sokra/NextFontIssue-issue-stage

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Apr 9, 2026

What?

Changes NextFontIssue's IssueStage from CodeGen to Resolve.

Why?

NextFontIssue is emitted during font resolution — when validating font configuration options (util.rs) and when fetching/resolving Google Font metadata (google/mod.rs, google/font_fallback.rs). None of these occur during code generation; they all happen at the resolve stage of the build pipeline.

Using IssueStage::CodeGen was incorrect and caused these font issues to be grouped/sorted with code generation errors rather than resolution errors. The local-font counterpart (FontResolvingIssue in next_font/local/mod.rs) already correctly uses IssueStage::Resolve.

How?

Single-line fix: change IssueStage::CodeGen.cell() to IssueStage::Resolve.cell() in the stage() method of impl Issue for NextFontIssue.

Font issues are about resolving font resources, not code generation.
This aligns with FontResolvingIssue (local fonts) which already uses Resolve.

Co-Authored-By: Claude <noreply@anthropic.com>
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Apr 9, 2026
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Apr 9, 2026

Tests Passed

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing sokra/NextFontIssue-issue-stage (fdbfbfb) with canary (3d2bab2)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mischnic mischnic marked this pull request as ready for review April 10, 2026 08:38
@sokra sokra merged commit 7d09d1e into canary Apr 10, 2026
313 of 320 checks passed
@sokra sokra deleted the sokra/NextFontIssue-issue-stage branch April 10, 2026 08:47
@sokra sokra restored the sokra/NextFontIssue-issue-stage branch April 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants