Fix NextFontIssue IssueStage: CodeGen → Resolve#92588
Merged
Conversation
Font issues are about resolving font resources, not code generation. This aligns with FontResolvingIssue (local fonts) which already uses Resolve. Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Tests Passed |
Merging this PR will not alter performance
Comparing Footnotes
|
mischnic
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changes
NextFontIssue'sIssueStagefromCodeGentoResolve.Why?
NextFontIssueis emitted during font resolution — when validating font configuration options (util.rs) and when fetching/resolving Google Font metadata (google/mod.rs,google/font_fallback.rs). None of these occur during code generation; they all happen at the resolve stage of the build pipeline.Using
IssueStage::CodeGenwas incorrect and caused these font issues to be grouped/sorted with code generation errors rather than resolution errors. The local-font counterpart (FontResolvingIssueinnext_font/local/mod.rs) already correctly usesIssueStage::Resolve.How?
Single-line fix: change
IssueStage::CodeGen.cell()toIssueStage::Resolve.cell()in thestage()method ofimpl Issue for NextFontIssue.