Potential fix for code scanning alert no. 6: DOM text reinterpreted as HTML#26
Merged
Potential fix for code scanning alert no. 6: DOM text reinterpreted as HTML#26
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/vannu07/jarvis/security/code-scanning/6
To fix the issue, all text coming from the DOM (via
t.text()) should be escaped before being added as HTML content using string concatenation and.append(). The best way is to properly encode theitemvariable before concatenation in line 18, so HTML metacharacters are converted to entities (e.g.,<becomes<). In jQuery, a common approach is to usedocument.createTextNodeto escape text, but since we are building HTML as a string, we need an explicit escaping function.itembefore concatenating.Suggested fixes powered by Copilot Autofix. Review carefully before merging.