Node: Fix flaky FLUSHALL timeout in commonjs-test.cjs - #6737
Draft
xShinnRyuu wants to merge 1 commit into
Draft
Conversation
…ALL timeout The FLUSHALL command in the commonjs-test.cjs hybrid node modules test was timing out after 250ms (the default) with ServerUnresponsive cause. The timeout_watchdog reported the system was already saturated at submission time in CI environments. Increase requestTimeout from the default 250ms to 5000ms, which is generous enough for CI environments under load while still catching actual connection issues. Signed-off-by: xShinnRyuu <xshinnryuu@users.noreply.github.com>
Contributor
|
Commit
Please amend the commit and force-push the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky FLUSHALL timeout in the commonjs-test.cjs hybrid node modules test by increasing the client's
requestTimeoutfrom the default 250ms to 5000ms.Issue link
This Pull Request is linked to issue: [Node][Flaky Test] commonjs-test.cjs - FLUSHALL timeout in hybrid node modules test
Closes #6736
Features / Behaviour Changes
No behaviour changes. This PR fixes test flakiness only.
Implementation
Root cause: The GlideClient in commonjs-test.cjs was using the default
requestTimeoutof 250ms. In CI environments (GitHub Actions runners) under load, the system can be saturated even at command submission time, causing simple commands like FLUSHALL to exceed this timeout. The timeout_watchdog confirmed: "system was already saturated at submission time."Fix: Set
requestTimeout: 5000(5 seconds) in theGlideClient.createClientconfiguration. This is generous enough for CI environments under load while still catching actual connection issues. This aligns with the pattern used in the main test suite (TestUtilities.ts uses 1000ms, and specific tests use up to 10000ms).Limitations
None
Testing
requestTimeoutconfiguration pattern used throughout the test suite (e.g.,node/tests/TestUtilities.tssets 1000ms by default,GlideClient.test.tsuses 10000ms for certain operations)Checklist