Open
Conversation
web-padawan
force-pushed
the
chore/bump-playwright-1.59
branch
3 times, most recently
from
b999b67 to
b43b806
Compare
web-padawan
commented
Apr 9, 2026
Member
Author
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
Some notes regarding screenshot updates:
- Chrome 145 added support for
focusVisible, and as we set it tofalseunlesskeyboardActive()is true - this caused the focus outline to disappear in dialog, CRUD and popover screenshots. - Custom Field likely had hover state for the label / helper text previously - presumably because its wrapper was lacking
padding: 10pxthat we use elsewhere, and by default the Playwright cursor was at 0, 0 position making:hoverapply.
web-padawan
force-pushed
the
chore/bump-playwright-1.59
branch
from
b43b806 to
cfd7680
Compare
Update Playwright from 1.56.0 to 1.59.1 and the corresponding Docker image in visual test workflows. Fix dashboard focus restoration in Firefox: when removing items, Firefox loses focus from a remaining widget if a sibling DOM element is removed. Save a reference to the focused element before DOM manipulation and restore it if focus was lost. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use getDeepActiveElement() to reliably find the focused row across browsers. Firefox returns the shadow host for document.activeElement when focus is on a slotted input, breaking the assignedSlot chain. Reduce tabToIndex from 20 to 10 to stay within the virtualizer's rendered row window — Firefox native Shift+Tab does not scroll virtualized rows into view. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
force-pushed
the
chore/bump-playwright-1.59
branch
from
cfd7680 to
bd29542
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Depends on #11467
Summary
package.json, Docker images in CI workflows)getDeepActiveElement()to reliably find the focused row across browsers, reducetabToIndexto stay within the virtualizer's rendered row windowVisual test screenshot updates
:focusto:focus-visible. Since overlays receive focus programmatically (.focus()), the browser's default outline no longer appears — this is correct behavior (no focus ring for non-keyboard focus)Test plan
🤖 Generated with Claude Code