Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 19.19% 19.18% -0.01%
==========================================
Files 68 68
Lines 10135 10139 +4
Branches 545 545
==========================================
Hits 1945 1945
- Misses 8190 8194 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Can you fix the tests? |
e28cc66 to
5aaa4cd
Compare
Author
|
Tests are fixed now, but I'm a bit confused by the coverage check. Is there anything I can do to make it come up as successful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command line value exposed by the kernel in
/proc/<pid>/cmdlinerepresents whitespace as NULL bytes.Using
read_to_string()on this directly will cause the output to join all parts of the original command into one long string.This PR adds a very simple fix to avoid this.
Before:
After: