Add warning when port forwards are used in bridged/shared mode#7705
Open
mstrofnone wants to merge 1 commit intoutmapp:mainfrom
Open
Add warning when port forwards are used in bridged/shared mode#7705mstrofnone wants to merge 1 commit intoutmapp:mainfrom
mstrofnone wants to merge 1 commit intoutmapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an inline warning note in the network configuration view that appears when the user selects 'Bridged' or 'Shared' network mode.
Problem
UTM's UI lets users add PortForward entries to a Bridged or Shared network adapter, but those forwards are silently ignored by the QEMU command-line generator because Apple's vmnet framework doesn't support hostfwd=. Users discover this empirically — port forwards just don't work, no warning given.
Solution
Added a note (in orange, using the footnote font) that appears only when network mode is Bridged or Shared, stating that port forwards are only honored in Emulated mode due to vmnet framework limitations.
The change is in Platform/Shared/VMConfigNetworkView.swift and only affects macOS (wrapped in #if os(macOS)).
Testing