fix: prevent crash from force unwrap in UTMRegistry and memory leak in UTMAppleVirtualMachine#7701
Open
caseydapro2020 wants to merge 2 commits intoutmapp:mainfrom
Open
fix: prevent crash from force unwrap in UTMRegistry and memory leak in UTMAppleVirtualMachine#7701caseydapro2020 wants to merge 2 commits intoutmapp:mainfrom
caseydapro2020 wants to merge 2 commits intoutmapp:mainfrom
Conversation
added 2 commits
May 5, 2026 23:18
Replace unsafe force unwraps with compactMap and direct value iteration to prevent crashes during concurrent registry access. - Line 41: Use compactMap instead of entries[key]! - Line 126: Iterate entries.values instead of force-unwrapping by key
Clear progressObserver and installProgress in the error path of installVM() to break the retain cycle caused by the KVO observation closure capturing self strongly.
caseydapro2020
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1: Prevent crash from force unwrap in UTMRegistry
Replace unsafe force unwraps with compactMap and direct value iteration to prevent crashes during concurrent registry access.
compactMapinstead ofentries[key]!in thedidSetobserverentries.valuesinstead of force-unwrapping by key incommitAll()This prevents potential crashes when registry entries are modified concurrently during debounce callbacks, which could occur when users rapidly create/delete VMs.
Fix 2: Memory leak in UTMAppleVirtualMachine when installation fails
Clear
progressObserverandinstallProgressin the error path ofinstallVM()to break the retain cycle caused by the KVO observation closure capturingselfstrongly.Without this fix, failed macOS installations cause the VM instance to be retained in memory until the next successful installation or app termination.
Testing
Both fixes were verified by successful builds.