-
-
Notifications
You must be signed in to change notification settings - Fork 368
Execute Steam InstallScripts during container setup #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
playday3008
wants to merge
13
commits into
utkarshdalal:master
Choose a base branch
from
playday3008:feat/steam-installscript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7a72ffa
feat: add InstallScript data classes for VDF parsing
playday3008 ba0d2d9
feat: parse per-depot installscript from Steam app metadata
playday3008 dca0ec0
feat: implement InstallScript VDF parser with env var expansion
playday3008 a7181d9
feat: implement InstallScript executor with registry writes and run p…
playday3008 d090254
feat: integrate InstallScript executor into game launch pipeline
playday3008 6ee10ff
style: fix import ordering and trailing comma in InstallScript files
playday3008 b2e196d
fix: discover install scripts from depot manifests via EDepotFileFlag
playday3008 40fff53
fix: address PR review findings in InstallScript executor and parser
playday3008 88a7d6d
feat: exit-code-based completion tracking for InstallScript run proce…
playday3008 c442dfb
fix: skip UbisoftConnectStep for Steam games, handled by InstallScript
playday3008 1aba313
feat: add PreLaunchSetup orchestrator with PreInstallStep chaining
playday3008 0847450
feat: add Steam InstallScript collection to PreLaunchSetup
playday3008 8b11e4a
refactor: use PreLaunchSetup in XServerScreen, remove domain logic
playday3008 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
app/src/main/java/app/gamenative/utils/installscript/InstallScriptData.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package app.gamenative.utils.installscript | ||
|
|
||
| data class RegistryValues( | ||
| val strings: Map<String, String> = emptyMap(), | ||
| val dwords: Map<String, Long> = emptyMap(), | ||
| ) | ||
|
|
||
| data class RegistryAction( | ||
| val keyPath: String, | ||
| val values: RegistryValues, | ||
| val languageOverrides: Map<String, RegistryValues> = emptyMap(), | ||
| ) | ||
|
|
||
| data class OSRequirement( | ||
| val is64BitWindows: Boolean? = null, | ||
| val osType: String? = null, | ||
| ) | ||
|
|
||
| data class RunProcessAction( | ||
| val name: String, | ||
| val process: String, | ||
| val command: String = "", | ||
| val hasRunKey: String? = null, | ||
| val noCleanUp: Boolean = false, | ||
| val minimumHasRunValue: Int = 0, | ||
| val requirementOS: OSRequirement? = null, | ||
| val asCurrentUser: Boolean = false, | ||
| ) | ||
|
|
||
| data class InstallScript( | ||
| val sourcePath: String, | ||
| val registryActions: List<RegistryAction> = emptyList(), | ||
| val runProcessActions: List<RunProcessAction> = emptyList(), | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valuable to add the registry keys, but the rest I'm not so sure about. We intentionally don't install some things (like xaudio on proton 9, directx on proton < 10). This should align with our preinstallsteps better. What kind of scripts have you seen here? And what errors get fixed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the testing with NFS Rivals, the InstallScript Run Process installs EA App (
EAAppInstaller.exe). Ubisoft titles similarly declare Ubisoft Connect installer. These are launcher/client prerequisites, not redists like VCRedist/DirectX/PhysX (those are already handled by PreInstallSteps).Concern about xaudio on proton 9 / directx on proton <10 is valid but may not apply here — InstallScript Run Processes are typically launcher installers, not the same redists that PreInstallSteps handles. That said, some games could declare DirectX/VCRedist in their InstallScript too, which would overlap.