fix: incorrect status assertion in User Info test and document environment selection (#2) (#3)#23
Open
AbdullahShafqat-OG wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in the Github REST API collection.
The
User Inforequest had a test labelled"status must be 200"but assertedres.statusagainst201, causing the test to fail against a valid GitHub response. The assertion now correctly checks for200.The readme also did not mention that the
Githubenvironment must be selected for{{baseUrl}}to resolve, leading to broken requests on first run. The usage section now instructs users to select theGithubenvironment in Bruno, and adds a CLI section showing how to pass it explicitly: