Convert uses of Vector to List/ArrayList#8
Open
tfmorris wants to merge 3 commits intousc-isi-i2:masterfrom
Open
Convert uses of Vector to List/ArrayList#8tfmorris wants to merge 3 commits intousc-isi-i2:masterfrom
tfmorris wants to merge 3 commits intousc-isi-i2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector is a Java 1.0 legacy class which is no longer recommended for use because it is synchronized, causing lower performance, and because it doesn't fit with the rest of the more modern Collections classes.
This pull request changes everything to use List in the API and ArrayList in the implementations.
Not done as part of this, but useful for as a next step would be to switch from using Enumerations (also no longer recommended) to Iterators. For this piece, to preserve API compatibility, I've introduced an adapter to class to convert iterators to enumerations where needed by the API.