🐛 Route GitHub rate-limit errors to rate-limit page - #567
Open
AnandChowdhary wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-ratelimit-remaining: 0errors to/rate-limit-exceededinstead of/error.Fixes upptime/upptime#1002
Test plan
npm ciwith Node 14.21.3 / npm 6.14.18npm run unit-test -- --runTestsByPath src/utils/createOctokit.spec.js --runInBandfailed before the fixnpm run unit-test -- --runTestsByPath src/utils/createOctokit.spec.js --runInBandnpm run unit-testnpm run buildnpm run testNotes
masterrelease job is already blocked by an invalidNPM_TOKENfrom the previous merge, so I do not expect to merge/release this until that release-infra blocker is handled.