Skip to content

🐛 Route GitHub rate-limit errors to rate-limit page - #567

Open
AnandChowdhary wants to merge 1 commit into
masterfrom
fix/upptime-maintenance-20260703
Open

🐛 Route GitHub rate-limit errors to rate-limit page#567
AnandChowdhary wants to merge 1 commit into
masterfrom
fix/upptime-maintenance-20260703

Conversation

@AnandChowdhary

Copy link
Copy Markdown
Member

Summary

  • Detect GitHub API rate-limit failures more robustly in the status-page client.
  • Route secondary rate-limit messages and x-ratelimit-remaining: 0 errors to /rate-limit-exceeded instead of /error.
  • Add focused Jest coverage for the error-routing helper.

Fixes upptime/upptime#1002

Test plan

  • npm ci with Node 14.21.3 / npm 6.14.18
  • RED: npm run unit-test -- --runTestsByPath src/utils/createOctokit.spec.js --runInBand failed before the fix
  • GREEN: npm run unit-test -- --runTestsByPath src/utils/createOctokit.spec.js --runInBand
  • npm run unit-test
  • npm run build
  • npm run test

Notes

  • This repo's current master release job is already blocked by an invalid NPM_TOKEN from the previous merge, so I do not expect to merge/release this until that release-infra blocker is handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic error page is shown instead of rate-limit page

1 participant