test(v0.7): add comprehensive unit tests for Kraftfile v0.7 parser#2782
Closed
alok-108 wants to merge 1 commit intounikraft:stagingfrom
Closed
test(v0.7): add comprehensive unit tests for Kraftfile v0.7 parser#2782alok-108 wants to merge 1 commit intounikraft:stagingfrom
alok-108 wants to merge 1 commit intounikraft:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the Kraftfile v0.7 schema parser introduced in #2776. This PR ensures correctness of parsing, error handling, and round-trip serialization.
Changes
pkg/app/schema/v0.7/parser_test.gowith table-driven tests.testdata/directory containing sample Kraftfiles (minimal, full, invalid, wrong version).Motivation
Comprehensive tests are essential for the new parser to be merged confidently. They validate the implementation against the v0.7 spec and prevent regressions.
Related Issue
Contributes to #2682
Testing Done
Notes for Reviewers
This PR is complementary to #2776 and does not modify any existing logic.
Dependency: This PR builds on the types defined in #2776. It should be merged into the
pr-2776branch first, or reviewed alongside it. Once #2776 is merged, this test suite can be directly integrated.