chore: bump Discord.Net 3.19.0-beta.1 → 3.20.1 (stable) — pending voice runtime test#49
Open
JacobHaig wants to merge 1 commit into
Open
chore: bump Discord.Net 3.19.0-beta.1 → 3.20.1 (stable) — pending voice runtime test#49JacobHaig wants to merge 1 commit into
JacobHaig wants to merge 1 commit into
Conversation
Supersedes Dependabot #42. The bot was pinned to the beta solely because the voice stream APIs the recorder uses (IAudioClient.GetStreams(), StreamCreated/StreamDestroyed, AudioInStream) were beta-only; they are present in stable as of 3.20.x. Verified to compile and build clean against this app. Also refreshes the now-stale csproj comment. NOT yet runtime-verified: a live voice-recording smoke test (join channel -> /recording start -> speak -> stop -> confirm WAV) is still recommended before relying on this in prod. Left as an open PR pending that test.
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesDiscord.Net Stable Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Wisbot.csproj`:
- Around line 17-22: Update the Discord.Net version documentation in CLAUDE.md
(around lines 98-100) to reflect the new stable version requirement. Replace the
reference to Discord.Net 3.19.0-beta.1 with 3.20.1, and update the accompanying
explanation to indicate that IAudioClient.GetStreams() and the required voice
stream APIs are now available in the stable 3.20.x release, removing the
outdated guidance that a beta version is needed for this functionality.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 935c08bf-d1bd-4741-a9aa-8ab41ba4d0ca
📒 Files selected for processing (1)
Wisbot.csproj
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: build
Comment on lines
+17
to
+22
| <!-- Discord.Net 3.20.1 (stable). The voice stream APIs the recorder needs | ||
| (IAudioClient.GetStreams(), StreamCreated/StreamDestroyed, AudioInStream) | ||
| are present in stable as of 3.20.x — verified to compile against this app. | ||
| A live voice-recording runtime test is still recommended before relying on | ||
| it in prod (the beta pin's original reason is otherwise resolved). --> | ||
| <PackageReference Include="Discord.Net" Version="3.20.1" /> |
There was a problem hiding this comment.
Sync dependency documentation to avoid conflicting guidance.
Lines 17-21 correctly explain the beta pin is no longer needed, but CLAUDE.md (Line 98-100 in the provided snippet) still says Discord.Net 3.19.0-beta.1 is required for IAudioClient.GetStreams(). Please update that doc in this PR so contributor guidance matches the actual 3.20.1 pin.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Wisbot.csproj` around lines 17 - 22, Update the Discord.Net version
documentation in CLAUDE.md (around lines 98-100) to reflect the new stable
version requirement. Replace the reference to Discord.Net 3.19.0-beta.1 with
3.20.1, and update the accompanying explanation to indicate that
IAudioClient.GetStreams() and the required voice stream APIs are now available
in the stable 3.20.x release, removing the outdated guidance that a beta version
is needed for this functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Supersedes Dependabot #42 (which only edited the version line and would have left a now-false csproj comment, and conflicted with the SQLite override on
main).The bot was pinned to 3.19.0-beta.1 for one reason: the voice stream APIs the recorder uses (
IAudioClient.GetStreams(),StreamCreated/StreamDestroyed,AudioInStream) were beta-only. They are present in stable as of 3.20.x.Verified
mainA live voice-recording runtime test — this can't be automated here (needs a running bot in a Discord voice channel):
/recording startin a voice channel/recording stop./recordings/Leaving this PR open until that passes. The compile gate (the original blocker) is cleared.