Skip to content

Updates for ccpp-capgen v1 - #3288

Open
dustinswales wants to merge 53 commits into
ufs-community:developfrom
dustinswales:feature/capgen-ng
Open

Updates for ccpp-capgen v1#3288
dustinswales wants to merge 53 commits into
ufs-community:developfrom
dustinswales:feature/capgen-ng

Conversation

@dustinswales

@dustinswales dustinswales commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Transparency in the use of generative AI is required by NOAA policy. Was GenAI used in this work?
    • [Generative AI tool (insert name, if any)] was used to assist with developing this code. The code has been reviewed, edited, and validated by NWS staff.
  • Fill out all sections of this template.

Description:

This PR contains the necessary changes to the CCPP interfaces for the new code generator capgen v1. Besides updates to the ccpp physics and framework, there are changes to CCPP interfaces in the fv3 dynamical core, ufs atmosphere, and CMEPS.

Commit Message:

* UFSWM - CCPP capgen v1
   * CMEPS - CCPP capgen v1
  * UFSATM - CCPP capgen v1
    * ccpp-physics - CCPP capgen v1
       * TEMPO -CCPP capgen v1 
       * C3 - CCPP capgen v1
    * ccpp-framework - CCPP capgen v1
    * atmos_cubed_sphere - CCPP capgen v1
    

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

N/A

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

N/A

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.
    Only change is to regional hail aware TEMPO RT. This is due to bug fixes in the TEMPO submodule for hail aware configurations. Global (not hailaware) TEMPO configurations are unimpacted.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

  • Skipping Acorn due to continued system unavailability.
  • Merging with failed warnings/remarks check because failures are only due to an increase in remark 10448 ifort deprecation, which will go away with the move to spack-stack v2.x.
  • ccpp/framework PR does not need to be merged; switching to new capgen branch instead. PR just shows diff for review.

Comment thread CMEPS-interface/CMEPS
export OUTPUT_FH="1 -1"

export CCPP_SUITE=FV3_HRRR
export CCPP_SUITE=FV3_HRRR_nolake

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated?

@gspetro-NOAA gspetro-NOAA added the UFSATM There are changes to the UFSATM repository. label Jul 10, 2026
@gspetro-NOAA gspetro-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Aug 3, 2026
@gspetro-NOAA gspetro-NOAA added the In Testing The PR that is currently in testing stages label Aug 3, 2026
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Aug 4, 2026
@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Aug 5, 2026
@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

RTs completed successfully; leaving a note in sub-PRs.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

Everything except s2s_aoflux_intel compiles. My test dir is: /scratch3/NAGAPE/epic/Gillian.Petro/ursa/RTs/ufs-wm/3288-compile/tests, and the err file is at /scratch4/NAGAPE/epic/Gillian.Petro/stmp/RT_RUNDIRS/Gillian.Petro/FV3_RT/rt_312632/compile_s2s_aoflux_intel/err.
The error I'm seeing is:

CMake Error at UFSATM/cmake/ccpp_capgen.cmake:102 (message):
  function(ccpp_validator): Could not find ccpp_validator.py.  Looked for
  /scratch3/NAGAPE/epic/Gillian.Petro/ursa/RTs/ufs-wm/3288-compile//ccpp/framework/capgen/ccpp_validator.py.
Call Stack (most recent call first):
  CMEPS-interface/CMakeLists.txt:177 (ccpp_validator)

@NickSzapiro-NOAA

Copy link
Copy Markdown
Collaborator

Since UFSATM/cmake/ccpp_capgen.cmake now has
set(CCPP_VALIDATOR_CMD_LIST "${CMAKE_SOURCE_DIR}/${PARENT_DIR}/ccpp/framework/capgen/ccpp_validator.py")
it looks like we have to
set(PARENT_DIR "UFSATM") before include(${UFSATM_PATH}/cmake/ccpp_capgen.cmake)
in CMEPS-interface/CMakeLists.txt

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

Since UFSATM/cmake/ccpp_capgen.cmake now has set(CCPP_VALIDATOR_CMD_LIST "${CMAKE_SOURCE_DIR}/${PARENT_DIR}/ccpp/framework/capgen/ccpp_validator.py") it looks like we have to set(PARENT_DIR "UFSATM") before include(${UFSATM_PATH}/cmake/ccpp_capgen.cmake) in CMEPS-interface/CMakeLists.txt

Thanks @NickSzapiro-NOAA! With this fix, everything compiles, and UFSATM CI is happy. I'm running the full RT suite on Ursa just to make sure all is well.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

With the changes in UFSATM and the CMEPS change that @NickSzapiro-NOAA suggested, CI is passing in UFSATM, and RTs are passing on Ursa. The WM warnings/remarks check is failing for allowable reasons (increase only in ifort deprecation remarks). The repo_check is failing because the CMEPS hash has not yet been updated to the authoritative branch at the WM level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3S There are changes to the atmos_cubed_sphere component repository. Baseline Updates Current baselines will be updated. CCPP There are changes to a CCPP repository. CMEPS There are changes to the CMEPS component repository. Priority: High Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. UFSATM There are changes to the UFSATM repository.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

7 participants