Adds asynchronous batch scanning - #1131
Closed
mbusch3 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
The biggest issue with serious asynchronous requests is that the Canvas API has a major throttle that makes it trickle out data at a slow and steady stream. Asking for 10 files at a time does not improve the performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS A DRAFT - DON'T USE UNTIL SCANNER CAN MASSIVELY SCALE
This change significantly improves scanning speed WHEN your local Docker Desktop can handle it. If the settings are too low, it actually INCREASES the amount of request timeout errors that the
udoit3-acecontainer returns. Those errors are almost certainly from scan requests that can't get through to the server because the container is overloaded.