chore: remove unused Impeccable project metadata - #160
Conversation
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Nice work on this! This is a clean and appropriately scoped repository cleanup. Removing the stale Impeccable sidecar without touching runtime code, package inputs, or generated artifacts keeps the change low-risk and easy to review.
The validation is also particularly strong for such a small change. Verifying all 744 tests, git diff --check, and the byte-identical release archive gives good confidence that this cleanup has no unintended impact. Great job keeping the PR focused and well-documented. 👏
tt-a1i
left a comment
There was a problem hiding this comment.
The cleanup is appropriately scoped, and the runtime/package evidence looks good, but one acceptance criterion from #158 is still missing.
The PR deletes .impeccable/design.json without adding a root-level ignore rule. The PR head’s .gitignore does not match .impeccable/, so the generated sidecar can be recommitted the next time the tool recreates it. Please add /.impeccable/ to .gitignore (root-anchored so nested paths are unaffected), then update the branch from current main and let the required checks rerun.
Code Review SummaryVerdict: Changes Requested 🔴 (1 blocking issue)
|
Problem and value
The repository still tracks a stale
.impeccable/design.jsonsidecar even though the project no longer uses Impeccable. Removing it eliminates an unused generated artifact and its maintenance obligation, while a root-anchored ignore rule prevents the sidecar from being recommitted.Closes #158
Scope
.impeccable/design.json(140 lines) and added/.impeccable/to the root.gitignore.DESIGN.md,PRODUCT.md, runtime code, schemas, renderers, tests, and release inputs.main.Stability impact
archify/..impeccable/design.jsonand remove the ignore rule if Impeccable is adopted again.Tests run
cd archify && npm test— 746 tests: 721 passed, 0 failed, 25 skipped.git diff --check upstream/main...HEAD— passed.git check-ignore --no-index -v .impeccable/design.json— matched root/.impeccable/; nested.impeccable/remained unaffected.scripts/build-zip.sh /tmp/archify-pr160-updated.zipfollowed by byte comparison — rebuilt archive was byte-identical toarchify.zip.Visual evidence
Not applicable; this is a non-visual repository metadata cleanup.
Generated artifacts
None changed. The removed root-level file and root ignore rule are outside the tracked-only
archify/package input, and the rebuilt archive is byte-identical.Checklist
npm testinarchify/.