fix: resume-able bulk insert from failed chunk#116
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe BulkInserter API is expanded across Go bindings, Python SDK, and documentation with differentiated retry/backoff policies: non-catchup transient attempts increase to 15 (from 5), catchup backoff increases to 15 seconds (from 5), a separate Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
Bug Report Checklist
If this commit or author is incorrect, reply in this PR with:
Use git blame to identify the right commit and author before posting. See available commands to help comply with our Guidelines. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bindings/bindings.go`:
- Line 231: The comment for progressLogEveryN in bindings.go claims the default
is 0 but the Python wrapper (bulk_inserter.py) sets a default of 500, causing
inconsistency; either update the Go-side comment to note that the Python wrapper
overrides the default or change the Python default to 0 to match Go. Locate the
symbol progressLogEveryN in bindings.go and either adjust its inline comment to
state "default 0 (overridden to 500 in Python bulk_inserter.py)" or change the
default value in bulk_inserter.py (the argument/variable that sets the 500
default) so both sides match. Ensure the chosen change is reflected in both
files' comments/argument defaults to avoid future drift.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1e0391b4-34be-497b-a272-ce6f1c4cabc2
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
README.mdbindings/bindings.godocs/api-reference.mdexamples/bulk_insert_example/README.mdgo.modsrc/trufnetwork_sdk_py/bulk_inserter.py
|
@holdex pr submit-time 3h |
resolves: https://github.com/truflation/website/issues/3697#issuecomment-4334258361
Summary by CodeRabbit
New Features
Documentation