Xpetra: Support transposes in matrix-matrix product for BlockedCrsMatrix type - #15172
Merged
MalachiTimothyPhillips merged 5 commits intoApr 27, 2026
Conversation
…ix multiplication Signed-off-by: malphil <malphil@sandia.gov>
…Matrix Signed-off-by: malphil <malphil@sandia.gov>
|
CDash for AT2 results [Currently only accessible from Sandia networks] Reproducing CI builds locallyCI builds can be reproduced locally in a container. Requirements: Python 3.9+, Podman, CMake Steps:
|
Signed-off-by: malphil <malphil@sandia.gov>
Signed-off-by: malphil <malphil@sandia.gov>
|
Your PR updated files that did not respect package formatting settings. Patchdiff --git a/packages/xpetra/src/Utils/Xpetra_MatrixMatrix_def.hpp b/packages/xpetra/src/Utils/Xpetra_MatrixMatrix_def.hpp
index e41f5dd6..af4d38ad 100644
--- a/packages/xpetra/src/Utils/Xpetra_MatrixMatrix_def.hpp
+++ b/packages/xpetra/src/Utils/Xpetra_MatrixMatrix_def.hpp
@@ -189,7 +189,8 @@ RCP<Xpetra::BlockedCrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node>> MatrixM
const size_t B_inner = transposeB ? B.Cols() : B.Rows();
TEUCHOS_TEST_FOR_EXCEPTION(A_inner != B_inner, Exceptions::RuntimeError,
"TwoMatrixMultiplyBlock: Block dimensions are not compatible for multiplication. "
- "A has " << A_inner << " block columns and B has " << B_inner << " block rows.");
+ "A has "
+ << A_inner << " block columns and B has " << B_inner << " block rows.");
RCP<const MapExtractor> rgmapextractor = transposeA ? A.getDomainMapExtractor() : A.getRangeMapExtractor();
RCP<const MapExtractor> domapextractor = transposeB ? B.getRangeMapExtractor() : B.getDomainMapExtractor();More details about our use of clang-format and other tools can be found in the wiki. |
Signed-off-by: malphil <malphil@sandia.gov>
cgcgcg
approved these changes
Apr 23, 2026
MalachiTimothyPhillips
enabled auto-merge (squash)
April 23, 2026 23:05
MalachiTimothyPhillips
disabled auto-merge
April 23, 2026 23:07
MalachiTimothyPhillips
merged commit Apr 27, 2026
854446a
into
trilinos:develop
25 of 28 checks passed
MalachiTimothyPhillips
deleted the
malachi/add-xpetra-transpose-matrix-matrix-multiply
branch
April 27, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@trilinos/xpetra