feat!: reserved rules api, enum consts, const attributes, 0.24.0#275
Merged
feat!: reserved rules api, enum consts, const attributes, 0.24.0#275
Conversation
67dd943 to
794d67e
Compare
794d67e to
9166e6b
Compare
Collaborator
Author
|
@amaanq, can you please look at this when you get the chance? I'm not sure if I'm doing something wrong (most likely) or if there's a bug in the This test should produce an ERROR: because |
9166e6b to
2206b02
Compare
Co-authored-by: Amaan Qureshi <amaanq12@gmail.com>
2206b02 to
5f4ad08
Compare
Collaborator
Author
|
@cfroystad, can you please review? I just forewent the failing test |
76cc103 to
0a3bdcc
Compare
0a3bdcc to
a54c9f2
Compare
Collaborator
Author
|
@cfroystad, just wanted to ping you for review, I hope everything is going good! |
Collaborator
|
Thanks for your patience and sorry for the delay! I've just been too busy. Will try to find time to review this week or next week the latest. At a glance, this looks very good! |
Collaborator
Author
|
No worries sir! I understand how busy life can get sometimes :) |
cfroystad
approved these changes
Aug 11, 2025
Roardom
added a commit
to Roardom/zed-php
that referenced
this pull request
Dec 16, 2025
To v0.24.2 and v0.1.7 respectfully. Enables features of PHP 8.4 and 8.5. - tree-sitter/tree-sitter-php#275 - `php_end_tag` was added - `callable` is no longer a keyword - tree-sitter/tree-sitter-php#237 - `string_value` was replaced with `string_content` - `modifier` field was removed from `class_declaration` - Various - `yield` and `from` are converted to `yield` and `yield from`
Roardom
added a commit
to Roardom/zed-php
that referenced
this pull request
Dec 16, 2025
To v0.24.2 and v0.1.7 respectively. Enables features of PHP 8.4 and 8.5. - tree-sitter/tree-sitter-php#275 - `php_end_tag` was added - `callable` is no longer a keyword - tree-sitter/tree-sitter-php#237 - `string_value` was replaced with `string_content` - `modifier` field was removed from `class_declaration` - Various - `yield` and `from` are converted to `yield` and `yield from`
Roardom
added a commit
to Roardom/zed-php
that referenced
this pull request
Jan 29, 2026
To v0.24.2 and v0.1.7 respectively. Enables features of PHP 8.4 and 8.5. - tree-sitter/tree-sitter-php#275 - `php_end_tag` was added - `callable` is no longer a keyword - tree-sitter/tree-sitter-php#237 - `string_value` was replaced with `string_content` - `modifier` field was removed from `class_declaration` - Various - `yield` and `from` are converted to `yield` and `yield from`
MrSubidubi
pushed a commit
to zed-extensions/php
that referenced
this pull request
Feb 2, 2026
To v0.24.2 and v0.1.7 respectively. Enables features of PHP 8.4 and 8.5. - tree-sitter/tree-sitter-php#275 - `php_end_tag` was added - `callable` is no longer a keyword - tree-sitter/tree-sitter-php#237 - `string_value` was replaced with `string_content` - `modifier` field was removed from `class_declaration` - Various - `yield` and `from` are converted to `yield` and `yield from`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes @amaanq's work in #263
Closes #272, closes #273, closes #279