fix: silence unused parameter warnings in scanner.c#380
Open
0x1050 wants to merge 1 commit intotree-sitter:masterfrom
Open
fix: silence unused parameter warnings in scanner.c#3800x1050 wants to merge 1 commit intotree-sitter:masterfrom
0x1050 wants to merge 1 commit intotree-sitter:masterfrom
Conversation
Add (void) casts for unused parameters in external scanner interface functions to improve compiler portability and silence warnings on stricter compiler configurations. Another fix would be to add 'CFLAGS += -Wno-unused-parameter' to the MakeFile, but that would have just hidden the error even if they might be a real bug. This only supresses them they need to be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
(void)casts for unused parameters in external scanner interface functions to silence compiler warnings and improve portability.The external scanner API requires these function signatures, but not all parameters are used in this implementation. Adding explicit void casts documents this is intentional and prevents warnings on stricter compiler configurations.
Alternative approaches like adding
-Wno-unused-parameterto CFLAGS would suppress all unused parameter warnings globally, potentially hiding real bugs elsewhere.