Shell completion to suggest installed version feature added (resolves #420) by RushabhRatnaparkhi · Pull Request #501 · tofuutils/tenv

RushabhRatnaparkhi · 2025-10-22T09:15:57Z

Summary
Implements bash completion for installed tool versions in tenv. Users can now press TAB after tenv use to see locally installed versions and common strategies like "latest".

Changes Made
Added ValidArgsFunction to use, install, and uninstall commands in cmd/tenv/subcmd.go
Completion shows installed versions (from LocalSet()) plus predefined strategies
Fast completion without file parsing overhead
Dependencies
No new dependencies required. Uses existing:

Cobra CLI framework (already in project)
tenv's version management system
Testing
Verified with both programmatic (tenv __complete) and real bash completion testing.

kvendingoldo · 2025-10-22T10:30:17Z

Looks file, thank you for PR!
@dvaumoron can you double-check it, please?

dvaumoron · 2025-12-08T23:26:03Z

 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
+	"maps"
+	"slices"


Can you move those two import up with the others standard library imports ?

dvaumoron · 2025-12-08T23:26:40Z

Can you fix the compilation issues ?

kvendingoldo · 2025-12-09T08:06:07Z

@@ -0,0 +1,69 @@
+# Bash Completion Implementation for tenv


I am not sure that we need this markdown file in a main. Just post it to MR body, please and remove from PR

I have removed the markdown, sorry it took so long , please let me know if there are any more changes you would like

Signed-off-by: RushabhRatnaparkhi <rushuratnaparkhi2@gmail.com>

Copilot

Pull request overview

This PR adds bash completion functionality for installed tool versions in tenv, allowing users to get autocomplete suggestions for locally installed versions and common strategies when using commands like tenv <tool> use, install, and uninstall.

Changes:

Added ValidArgsFunction implementations to the use, install, and uninstall commands for shell completion
Introduced package-level commonVersionStrategies variable containing common version selection strategies
Added test_completion.sh script to demonstrate and test the completion functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
cmd/tenv/subcmd.go	Added completion logic to use, install, and uninstall commands; imported maps and slices packages; defined common version strategies
test_completion.sh	New test script to demonstrate bash completion functionality for different commands and tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T07:54:56Z

 }

-func newUninstallCmd(versionManager versionmanager.VersionManager) *cobra.Command {
+func newUninstallCmd(versionManager versionmanager.VersionManager, params subCmdParams) *cobra.Command {


The function signature for newUninstallCmd has been changed to accept a params parameter, but the call site in cmd/tenv/tenv.go at line 261 still calls it with only one argument (versionManager). This will cause a compilation error. The function signature should either be reverted to match the original signature without params, or the call site needs to be updated to pass the params argument.

Suggested change

func newUninstallCmd(versionManager versionmanager.VersionManager, params subCmdParams) *cobra.Command {

func newUninstallCmd(versionManager versionmanager.VersionManager) *cobra.Command {

Copilot · 2026-01-15T07:54:56Z

+			    conf := versionManager.Conf 
+			// Initialize config for completion
+			conf.InitDisplayer(true) // quiet mode for completion


There is a syntax error with incorrect indentation and spacing. The line should be properly aligned with the rest of the code, and the variable declaration "conf := versionManager.Conf" is unnecessary as conf.InitDisplayer is being called directly without using the conf variable elsewhere in this function.

Suggested change

conf := versionManager.Conf

// Initialize config for completion

conf.InitDisplayer(true) // quiet mode for completion

// Initialize config for completion

versionManager.Conf.InitDisplayer(true) // quiet mode for completion

Copilot · 2026-01-15T07:54:56Z

 }

-func newUninstallCmd(versionManager versionmanager.VersionManager) *cobra.Command {
+func newUninstallCmd(versionManager versionmanager.VersionManager, params subCmdParams) *cobra.Command {


The params parameter is accepted by this function but never used. Since params is not utilized in this function, it should either be removed from the function signature (reverting to the original signature) or be prefixed with an underscore (_params) to indicate it's intentionally unused.

Suggested change

func newUninstallCmd(versionManager versionmanager.VersionManager, params subCmdParams) *cobra.Command {

func newUninstallCmd(versionManager versionmanager.VersionManager, _params subCmdParams) *cobra.Command {

Copilot · 2026-01-15T07:54:57Z

+			// Get local versions using one-liner
+			localVersions := slices.Collect(maps.Keys(versionManager.LocalSet()))
+
+			// Use global variable 


The comment says "Use global variable" but this is misleading as commonVersionStrategies is a package-level variable, not a global variable. Consider removing this comment or clarifying it to say "Use package-level strategies" to better reflect the code structure.

Suggested change

// Use global variable

// Use package-level strategies

Copilot · 2026-01-15T07:54:57Z

+			// Combine local versions and strategies
+			versions := make([]string, 0, len(localVersions)+len(commonVersionStrategies))
+			versions = append(versions, localVersions...)
+			versions = append(versions, commonVersionStrategies...)


The order in which versions are presented to the user is inconsistent across commands. In the install command (line 168), common strategies are appended first followed by local versions, while in the use command (lines 432-434), local versions are appended first followed by strategies. This inconsistency makes the user experience less predictable. Consider standardizing the order across all commands - either always show local versions first, or always show strategies first.

Suggested change

// Combine local versions and strategies

versions := make([]string, 0, len(localVersions)+len(commonVersionStrategies))

versions = append(versions, localVersions...)

versions = append(versions, commonVersionStrategies...)

// Combine strategies and local versions (strategies first, to match install command)

versions := make([]string, 0, len(localVersions)+len(commonVersionStrategies))

versions = append(versions, commonVersionStrategies...)

versions = append(versions, localVersions...)

Copilot · 2026-01-15T07:54:58Z

+source /tmp/tenv_completion.bash
+
+echo "Building tenv..."
+make build > /dev/null 2>&1


The script silences both stdout and stderr when building (line 14), which could hide important build errors that would cause subsequent tests to fail in unexpected ways. Consider redirecting only stdout to /dev/null and allowing stderr to be visible, or check the exit code and fail early if the build fails.

Suggested change

make build > /dev/null 2>&1

if ! make build > /dev/null; then

echo "Build failed, aborting completion tests." >&2

exit 1

fi

Copilot · 2026-01-15T07:54:58Z

+echo "Installing a couple of OpenTofu versions for testing..."
+./build/tenv tofu install 1.10.5 > /dev/null 2>&1
+./build/tenv tofu install 1.10.6 > /dev/null 2>&1


The script does not check for errors when installing test versions (lines 17-18). If these installations fail silently, the subsequent completion tests may produce misleading results or false positives. Consider checking exit codes and reporting installation failures, or at least verifying that the expected versions were actually installed before running the completion tests.

Suggested change

echo "Installing a couple of OpenTofu versions for testing..."

./build/tenv tofu install 1.10.5 > /dev/null 2>&1

./build/tenv tofu install 1.10.6 > /dev/null 2>&1

install_tofu_version() {

local version="$1"

if ! ./build/tenv tofu install "$version" > /dev/null 2>&1; then

echo "Error: Failed to install OpenTofu version ${version} for completion tests." >&2

exit 1

fi

}

echo "Installing a couple of OpenTofu versions for testing..."

install_tofu_version "1.10.5"

install_tofu_version "1.10.6"

RushabhRatnaparkhi force-pushed the main branch 2 times, most recently from a5139b1 to 230d715 Compare October 22, 2025 09:36

kvendingoldo added hacktoberfest hacktoberfest-accepted labels Oct 22, 2025

dvaumoron reviewed Nov 2, 2025

View reviewed changes

Comment thread cmd/tenv/subcmd.go Outdated

dvaumoron reviewed Nov 2, 2025

View reviewed changes

Comment thread cmd/tenv/subcmd.go Outdated

RushabhRatnaparkhi force-pushed the main branch from 3a9500f to c27cbd3 Compare November 21, 2025 19:21

dvaumoron approved these changes Dec 8, 2025

View reviewed changes

dvaumoron reviewed Dec 8, 2025

View reviewed changes

kvendingoldo reviewed Dec 9, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 07:52

Copilot started reviewing on behalf of RushabhRatnaparkhi January 15, 2026 07:52 View session

RushabhRatnaparkhi added 4 commits January 15, 2026 13:24

issue resolved

367ac54

Signed-off-by: RushabhRatnaparkhi <rushuratnaparkhi2@gmail.com>

completion feature complete

bfe5b7d

Signed-off-by: RushabhRatnaparkhi <rushuratnaparkhi2@gmail.com>

requested changes made

f184ea7

Signed-off-by: RushabhRatnaparkhi <rushuratnaparkhi2@gmail.com>

markdown removed and issue of failing checks solved

173c454

Signed-off-by: RushabhRatnaparkhi <rushuratnaparkhi2@gmail.com>

Copilot AI reviewed Jan 15, 2026

View reviewed changes

RushabhRatnaparkhi force-pushed the main branch from a31dda8 to 173c454 Compare January 15, 2026 07:56

jakubfronczyk mentioned this pull request Apr 29, 2026

Shell completion to suggest installed versions with tenv <tool> use #420

Closed

	func newUninstallCmd(versionManager versionmanager.VersionManager, params subCmdParams) *cobra.Command {
	func newUninstallCmd(versionManager versionmanager.VersionManager) *cobra.Command {

-make build > /dev/null 2>&1
+if ! make build > /dev/null; then
+    echo "Build failed, aborting completion tests." >&2
+    exit 1
+fi

-echo "Installing a couple of OpenTofu versions for testing..."
-./build/tenv tofu install 1.10.5 > /dev/null 2>&1
-./build/tenv tofu install 1.10.6 > /dev/null 2>&1
+install_tofu_version() {
+    local version="$1"
+    if ! ./build/tenv tofu install "$version" > /dev/null 2>&1; then
+        echo "Error: Failed to install OpenTofu version ${version} for completion tests." >&2
+        exit 1
+    fi
+}
+echo "Installing a couple of OpenTofu versions for testing..."
+install_tofu_version "1.10.5"
+install_tofu_version "1.10.6"

Uh oh!

Conversation

RushabhRatnaparkhi commented Oct 22, 2025

Uh oh!

kvendingoldo commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

dvaumoron Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

dvaumoron commented Dec 8, 2025

Uh oh!

kvendingoldo Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

RushabhRatnaparkhi Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants