Skip to content

Remove max-height restriction from mermaid preview container#14882

Open
001-mak wants to merge 2 commits intotoeverything:canaryfrom
001-mak:001-mak/fix/14874/mermaid-preview
Open

Remove max-height restriction from mermaid preview container#14882
001-mak wants to merge 2 commits intotoeverything:canaryfrom
001-mak:001-mak/fix/14874/mermaid-preview

Conversation

@001-mak
Copy link
Copy Markdown
Contributor

@001-mak 001-mak commented Apr 28, 2026

This PR fixes issue #14874

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Removed height limitation on Mermaid diagram previews in code blocks, allowing larger diagrams to render at their full size without being constrained by a fixed maximum height.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

📝 Walkthrough

Walkthrough

Removed the max-height: 600px styling constraint from the Mermaid preview container. The rendered SVG area can now expand beyond 600px vertically when needed, with min-height: 300px as the only height restriction.

Changes

Cohort / File(s) Summary
Mermaid Preview Styling
packages/frontend/core/src/blocksuite/view-extensions/code-block-preview/mermaid-preview.ts
Removed max-height: 600px constraint from preview container, allowing SVG rendering area to grow dynamically beyond previous limit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and accurately describes the main change—removing the max-height restriction from the mermaid preview container styling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@001-mak 001-mak changed the title Remove max-height restriction from mermaidpreview container Remove max-height restriction from mermaid preview container Apr 28, 2026
@001-mak
Copy link
Copy Markdown
Contributor Author

001-mak commented Apr 28, 2026

@darkskygit please review and merge

@darkskygit darkskygit force-pushed the canary branch 5 times, most recently from 3403237 to 78a9942 Compare April 29, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant