fix(android): keyboard issues in BottomNavigation and androidback issue - #14537
Open
m1ga wants to merge 8 commits into
Open
fix(android): keyboard issues in BottomNavigation and androidback issue#14537m1ga wants to merge 8 commits into
androidback issue#14537m1ga wants to merge 8 commits into
Conversation
androidback issue
…/titanium-sdk into androidFixBottomNavigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14536
androidbacknow fires on the activity proxy when it has listeners (the legacy tabGroup.activity / win.activity.addEventListener('androidback', ...) pattern), and only falls back to the window proxy otherwise — exactly the priority the old KEYCODE_BACK branch in dispatchKeyEvent() used before predictive back made it dead code on API 33+.Test code
Fixed another app caused by the
exitOnClosechanges after checking a client app:The app was calling a
close()method in a previous window after opening a new controller. It was callingclose()twice and was working like this in all other SDK versions besides this PR. It's fixed now and the app and test code below only closes one window, even you call close() twice: