fix(PythonCodeTableWriter): emit float("-inf") for negative infinity#81
Open
gaoflow wants to merge 1 commit into
Open
fix(PythonCodeTableWriter): emit float("-inf") for negative infinity#81gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
dataproperty normalises every infinity value to Decimal('Infinity'),
losing the sign before the type_value_map substitution runs.
As a result, -inf was rendered as float("inf") — valid syntax but
the wrong value — producing Python code that silently evaluates to
positive infinity.
Override _to_row_item to detect when the original value in
value_matrix is a negative infinity float and substitute the correct
float("-inf") literal.
Add a parametrised test case covering -inf, +inf, and nan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PythonCodeTableWriterrendersfloat("-inf")(negative infinity) asfloat("inf")— valid Python syntax but the wrong value, silentlyproducing positive infinity when the generated code is executed.
Before this fix:
Root cause
datapropertynormalises every infinity value toDecimal('Infinity')before
type_value_mapis applied, losing the sign. Bothmath.infand
-math.inftherefore hit the same map entry{Typecode.INFINITY: 'float("inf")'}.Fix
Override
_to_row_iteminPythonCodeTableWriterto check theoriginal value in
value_matrixwhen the mapped literal isfloat("inf"). If the original was a negative-infinity float,substitute
float("-inf")instead.After this fix
Tests
Added a parametrised test case covering
-inf,+inf, andnantotest/writer/text/sourcecode/test_python_code_writer.py.This pull request was prepared with the assistance of AI, under my direction and review.