Open
Conversation
Member
|
Can one of the admins verify this patch? |
1 similar comment
Member
|
Can one of the admins verify this patch? |
4 tasks
Member
|
Ok to test |
Member
|
Test "rpm" complains about |
9e17d8c to
06dc357
Compare
Author
|
Fixed - the changelog date is now CI should pass now, thanks for catching that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update nodejs-uuid from 3.4.0 to 13.0.0 (RFC 9562, adds v6 and v7 UUIDs).
Required by theforeman/foreman#10944 which migrates foreman core from uuid v1 to v7.
Changes
Question for maintainers
After theforeman/foreman#10944 merges, foreman.spec will need its Requires/BuildRequires updated from npm(uuid) >= 3.3.2 < 4.0.0 to >= 13.0.0 < 14.0.0. Should that be a separate PR here (like #12157 was for the vendor removal), or is there a preferred way to coordinate this?
Packages that bundle their own uuid 3.x (patternfly-react, patternfly-react-extensions) are unaffected.