Skip to content

Block cg#164

Open
pierrenodet wants to merge 18 commits intotfjgeorge:mainfrom
pierrenodet:block-cg
Open

Block cg#164
pierrenodet wants to merge 18 commits intotfjgeorge:mainfrom
pierrenodet:block-cg

Conversation

@pierrenodet
Copy link
Copy Markdown
Contributor

@pierrenodet pierrenodet commented Feb 10, 2026

solvePFMap for PMatImplicit.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.22%. Comparing base (c04b984) to head (68c04c6).

Files with missing lines Patch % Lines
nngeometry/solve.py 96.42% 2 Missing ⚠️
nngeometry/object/fspace.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   95.76%   96.22%   +0.46%     
==========================================
  Files          23       23              
  Lines        3045     3127      +82     
==========================================
+ Hits         2916     3009      +93     
+ Misses        129      118      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tfjgeorge
Copy link
Copy Markdown
Owner

I am stalling this PR for now, it requires tools that are missing at the moment, namely: an API to deal with non-symmetric FMats, and adjoint PFMaps and FMats with specific unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants