Skip to content

PS-7124 : Zoom Attendance Related Changes (Initially Implemented Solution)#213

Open
Tejashrimajage wants to merge 2 commits into
tekdi:release-1.0.1from
Tejashrimajage:zoom-changes
Open

PS-7124 : Zoom Attendance Related Changes (Initially Implemented Solution)#213
Tejashrimajage wants to merge 2 commits into
tekdi:release-1.0.1from
Tejashrimajage:zoom-changes

Conversation

@Tejashrimajage

Copy link
Copy Markdown
Contributor

…tion)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SubjectCard component to open Zoom URLs directly using Linking.openURL instead of displaying a modal. The review feedback suggests handling potential promise rejections from Linking.openURL with a .catch() block and removing the commented-out code along with any unused state or modal components to avoid dead code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +58 to +59
// setShowZoomModal(true);
Linking.openURL(item.onlineDetails.url);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Calling Linking.openURL returns a Promise that can reject if the URL is invalid or if there is no application installed to handle the URL scheme. To prevent unhandled promise rejections (which can cause app crashes or silent failures), you should handle potential errors using a .catch() block.

Additionally, since setShowZoomModal(true) is commented out, the showZoomModal state variable and the corresponding <Modal> component (lines 210-233) are now dead code. Please remove them and the commented-out line to keep the codebase clean.

      Linking.openURL(item.onlineDetails.url).catch((error) => {
        console.error('Failed to open Zoom URL:', error);
      });

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant