PS-7124 : Zoom Attendance Related Changes (Initially Implemented Solution)#213
PS-7124 : Zoom Attendance Related Changes (Initially Implemented Solution)#213Tejashrimajage wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the SubjectCard component to open Zoom URLs directly using Linking.openURL instead of displaying a modal. The review feedback suggests handling potential promise rejections from Linking.openURL with a .catch() block and removing the commented-out code along with any unused state or modal components to avoid dead code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| // setShowZoomModal(true); | ||
| Linking.openURL(item.onlineDetails.url); |
There was a problem hiding this comment.
Calling Linking.openURL returns a Promise that can reject if the URL is invalid or if there is no application installed to handle the URL scheme. To prevent unhandled promise rejections (which can cause app crashes or silent failures), you should handle potential errors using a .catch() block.
Additionally, since setShowZoomModal(true) is commented out, the showZoomModal state variable and the corresponding <Modal> component (lines 210-233) are now dead code. Please remove them and the commented-out line to keep the codebase clean.
Linking.openURL(item.onlineDetails.url).catch((error) => {
console.error('Failed to open Zoom URL:', error);
});
|



…tion)