Name the example inf iterator of iterators sequence#22
Merged
michaelficarra merged 3 commits intotc39:mainfrom Apr 9, 2025
Merged
Name the example inf iterator of iterators sequence#22michaelficarra merged 3 commits intotc39:mainfrom
michaelficarra merged 3 commits intotc39:mainfrom
Conversation
Calling the helper function p() is a bit confusing because the p-series is a kinda well-known infinite series (1 + 1/(2^p) + 1/(3^p) + ...) I've chosen a name from one of the references listed by the Online Encyclopedia of Integer Sequences for this sequence. https://oeis.org/A002024 As an unrelated change, I've added a link to MDN for `flatMap`, because I didn't know that it existed for iterators, or precisely what it does.
|
Thanks. Could the new names be in camelCase? Snake_case is not idiomatic in JS. |
Co-authored-by: Michael Ficarra <github@michael.ficarra.me>
cmcaine
commented
Apr 9, 2025
michaelficarra
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the helper function p() is a bit confusing because the p-series is a kinda well-known infinite series, and the example function isn't for that series. The p series is 1 + 1/(2^p) + 1/(3^p) + ...
The example sequence is https://oeis.org/A002024. I picked a name for the functions from the references listed by the Online Encyclopedia of Integer Sequences.
As an unrelated change, I've added a link to MDN for
flatMap, because I didn't know that it existed for iterators, or precisely what it does.