fix: correct attach_yaml name in MQTT request and simplify grpc warnings - #1066
Merged
michaelboulton merged 1 commit intoJul 2, 2026
Conversation
- Fix copy-paste bug in mqtt/request.py: attach_yaml name was 'rest_request' instead of 'mqtt_request', causing incorrect labeling in test reports - Replace 5 brittle hardcoded lineno filterwarnings in grpc/__init__.py with a single module-level filter for pkg_resources DeprecationWarnings. The hardcoded line numbers break when dependencies update.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR makes two small, unrelated edits: the gRPC plugin now suppresses pkg_resources DeprecationWarning with a single rule instead of multiple lineno-specific filters, and the MQTT request plugin labels its attached YAML payload as "mqtt_request" instead of "rest_request". ChangesMiscellaneous plugin fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
michaelboulton
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct attach_yaml name in MQTT request and simplify grpc warnings
Summary
Two small, tangible fixes:
Bug: Wrong
attach_yamlname in MQTT request — mqtt/request.py usedname="rest_request"(copy-paste from REST plugin) instead ofname="mqtt_request". This caused MQTT request payloads to be incorrectly labeled asrest_requestin test reports and allure attachments.Bug: Fragile
pkg_resourceswarning suppression — grpc/init.py had 5 separatewarnings.filterwarningscalls with hardcodedlinenovalues (e.g.lineno=2804). These line numbers are specific to a particular version ofpkg_resourcesand silently stop working when the dependency updates. Replaced with a single module-level filter that suppresses allDeprecationWarningfrompkg_resourcesregardless of line number.Changes
name="rest_request"→name="mqtt_request"linenofilters → 1 module-level filterTesting
Summary by CodeRabbit