Conversation
- Add tavern entry points for http, mqtt, grpc, and graphql plugins
📝 WalkthroughWalkthroughThis change restores missing entry point registrations for three Tavern plugins (MQTT, gRPC, GraphQL) that were removed in version 3.1.0, and updates the tox test configuration to include MQTT extras for the HTTP integration test environment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tox-integration.ini (1)
32-33: Prefer a dedicated regression env instead of changing baselinehttpextras.
http: mqttmakes the HTTP integration env implicitly depend on MQTT packages. A dedicated env keeps baseline HTTP coverage clean and makes the regression intent explicit.Proposed refactor
[tox] -envlist = py3-{generic,mqtt,grpc,http,graphql,noextra} +envlist = py3-{generic,mqtt,grpc,http,http-mqtt-regression,graphql,noextra} @@ changedir = grpc: example/grpc mqtt: example/mqtt http: example/http + http-mqtt-regression: example/http graphql: example/graphql @@ extras = mqtt: mqtt grpc: grpc ; regression test for https://github.com/taverntesting/tavern/issues/1016 - http: mqtt + http-mqtt-regression: mqtt graphql: graphql🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tox-integration.ini` around lines 32 - 33, Remove the implicit mqtt dependency from the baseline HTTP extras by deleting the line "http: mqtt" and instead add a dedicated regression environment (e.g., a new testenv named something like "regression-http-mqtt" or "http-mqtt") that explicitly includes both http and mqtt extras; update the envlist to include that new env so the regression is exercised without making the base "http" extra depend on MQTT.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tox-integration.ini`:
- Around line 32-33: Remove the implicit mqtt dependency from the baseline HTTP
extras by deleting the line "http: mqtt" and instead add a dedicated regression
environment (e.g., a new testenv named something like "regression-http-mqtt" or
"http-mqtt") that explicitly includes both http and mqtt extras; update the
envlist to include that new env so the regression is exercised without making
the base "http" extra depend on MQTT.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1bbb9b6d-81b1-4998-a6a8-3d4abbfc9012
📒 Files selected for processing (2)
pyproject.tomltox-integration.ini
Fixes #1016
Summary by CodeRabbit
Chores