Skip to content

Fix/1016#1017

Merged
michaelboulton merged 2 commits intomasterfrom
fix/1016
Apr 8, 2026
Merged

Fix/1016#1017
michaelboulton merged 2 commits intomasterfrom
fix/1016

Conversation

@michaelboulton
Copy link
Copy Markdown
Member

@michaelboulton michaelboulton commented Apr 8, 2026

Fixes #1016

Summary by CodeRabbit

Chores

  • Enabled setuptools entry points for MQTT, gRPC, and GraphQL plugin integration.
  • Updated test environment configuration to include MQTT support for HTTP integration testing.

- Add tavern entry points for http, mqtt, grpc, and graphql plugins
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

This change restores missing entry point registrations for three Tavern plugins (MQTT, gRPC, GraphQL) that were removed in version 3.1.0, and updates the tox test configuration to include MQTT extras for the HTTP integration test environment.

Changes

Cohort / File(s) Summary
Plugin Entry Points
pyproject.toml
Added three missing entry point groups: tavern_mqtt mapping to the MQTT plugin, tavern_grpc mapping to the gRPC plugin, and tavern_graphql mapping to the GraphQL plugin.
Test Configuration
tox-integration.ini
Updated extras mapping to include http: mqtt, ensuring the HTTP integration test environment loads the MQTT extra dependency set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The changes in tox-integration.ini appear out of scope; adding an 'http: mqtt' extras mapping is unrelated to the entry points issue and not mentioned in the linked issue. Review whether the tox-integration.ini changes are necessary for fixing #1016; if not, remove them or explain their relevance in the PR description.
Title check ❓ Inconclusive The title 'Fix/1016' is vague and does not clearly convey the actual change; it only references the issue number without describing what was fixed. Use a more descriptive title that explains the fix, such as 'Re-add missing stevedore entry points for MQTT, gRPC, and GraphQL plugins'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request successfully re-adds the missing entry points for tavern_mqtt, tavern_grpc, and tavern_graphql in pyproject.toml, directly addressing the primary objective of issue #1016.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1016

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tox-integration.ini (1)

32-33: Prefer a dedicated regression env instead of changing baseline http extras.

http: mqtt makes the HTTP integration env implicitly depend on MQTT packages. A dedicated env keeps baseline HTTP coverage clean and makes the regression intent explicit.

Proposed refactor
 [tox]
-envlist = py3-{generic,mqtt,grpc,http,graphql,noextra}
+envlist = py3-{generic,mqtt,grpc,http,http-mqtt-regression,graphql,noextra}
@@
 changedir =
     grpc: example/grpc
     mqtt: example/mqtt
     http: example/http
+    http-mqtt-regression: example/http
     graphql: example/graphql
@@
 extras =
     mqtt: mqtt
     grpc: grpc
     ; regression test for https://github.com/taverntesting/tavern/issues/1016
-    http: mqtt
+    http-mqtt-regression: mqtt
     graphql: graphql
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tox-integration.ini` around lines 32 - 33, Remove the implicit mqtt
dependency from the baseline HTTP extras by deleting the line "http: mqtt" and
instead add a dedicated regression environment (e.g., a new testenv named
something like "regression-http-mqtt" or "http-mqtt") that explicitly includes
both http and mqtt extras; update the envlist to include that new env so the
regression is exercised without making the base "http" extra depend on MQTT.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tox-integration.ini`:
- Around line 32-33: Remove the implicit mqtt dependency from the baseline HTTP
extras by deleting the line "http: mqtt" and instead add a dedicated regression
environment (e.g., a new testenv named something like "regression-http-mqtt" or
"http-mqtt") that explicitly includes both http and mqtt extras; update the
envlist to include that new env so the regression is exercised without making
the base "http" extra depend on MQTT.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1bbb9b6d-81b1-4998-a6a8-3d4abbfc9012

📥 Commits

Reviewing files that changed from the base of the PR and between 3ac3401 and c108f9f.

📒 Files selected for processing (2)
  • pyproject.toml
  • tox-integration.ini

@michaelboulton michaelboulton merged commit a5d8712 into master Apr 8, 2026
12 checks passed
@michaelboulton michaelboulton deleted the fix/1016 branch April 8, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing entry_points for tavern_mqtt and tavern_grpc since 3.1.0

1 participant