chore:Remove swc_bundler#11936
Conversation
|
Merging this PR will degrade performance by 2.68%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | es/lints/libs/three |
49.2 ms | 50.5 ms | -2.68% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing hardfist:remove-swc-bundler (3597e10) with main (a71c8eb)
Footnotes
-
120 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
💡 Codex ReviewLines 285 to 287 in 3597e10 When a Flow file is parsed with Line 6 in 3597e10 For users running the still-declared ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kdy1
left a comment
There was a problem hiding this comment.
Note: This requires v2 because of the API removal
Description:
Removes
swc_bundlerandswc_node_bundlerfrom the workspace, along with the Node binding and@swc/corebundle/spackAPIs that depended on them. This also removes related features, CI/publish wiring, package tests, and lockfile references.While validating the removal, this PR fixes test failures that surfaced in the full workspace run:
node_modules._using_ctxhelper expectation.swc_ecma_quotedoctests.Verification:
git submodule update --init --recursivepnpm install --frozen-lockfilecargo fmt --all --checkcargo clippy --all --all-targets -- -D warningscargo test --all(cd packages/core && pnpm build:dev && pnpm test)rg -n "swc_bundler|swc_node_bundler|bundler_node|swc_core/bundler" Cargo.toml Cargo.lock crates bindings packages scripts .github --glob '!target' --glob '!node_modules'BREAKING CHANGE:
swc_bundler,swc_node_bundler, and the@swc/corebundle/spackAPIs have been removed.Related issue (if exists):
None.