fix(style): add gap to auth button wrapper for improved layout#10787
Open
alexechoi wants to merge 1 commit intoswagger-api:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the
gapspacing for auth action buttons from an inline style inauths.jsxto the existing.auth-btn-wrapperclass in_authorize.scss. This ensures consistent button spacing across all auth dialogs (both non-OAuth and OAuth2) and follows the project's convention of using SCSS stylesheets over inline styles.Motivation and Context
Current state

The authorize/logout and close buttons in the auth modal had no spacing between them. A
gap: 10pxwas added as an inline style inauths.jsx, but this only fixed the non-OAuth auth dialog and didn't follow the repo's styling convention. Moving it to the SCSS stylesheet fixes the spacing for all usages of.auth-btn-wrapper, including the OAuth2 dialog inoauth2.jsx.How Has This Been Tested?
.auth-btn-wrapperclass is used in bothauths.jsxandoauth2.jsxdisplay: flex, sogapapplies correctlyScreenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests
This is a simple UI improvement so does not need any additional tests