fix(removeUselessStrokeAndFill): handle transparent colors#2173
Open
viralcodex wants to merge 1 commit intosvg:mainfrom
Open
fix(removeUselessStrokeAndFill): handle transparent colors#2173viralcodex wants to merge 1 commit intosvg:mainfrom
viralcodex wants to merge 1 commit intosvg:mainfrom
Conversation
- Added isTransparent utility to detect transparent and zero-alpha color values for fill and stroke attributes. - Updated removeUselessStrokeAndFill plugin to treat these values as 'none', improving SVG cleanup. - New tests to verify correct removal of elements with transparent or zero fill/stroke.
Contributor
Author
|
Hi @SethFalco, can we have a review on this? Would love to know if it is needed or not/enhance it in anyway. thanks 😄 |
KTibow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2043
Hi @SethFalco and team,
I initially thought of adding the code changes with removeHiddenElems, but it was getting tricky with the previous checks and to integrate with them, the checks for the transparency and color alpha 0.
I felt it would be better to have the enhancements in the removeUselessStrokeAndFill, which already handled most of it from what I understood (can be wrong ofc).
Can be reviewed and let me know if any changes are needed or we can do it in some other way also.
Let me know what u think.
Thanks and have a great day!