inlineStyles plugin should not remove id attribute from target element#2066
Open
johnkenny54 wants to merge 3 commits intosvg:mainfrom
Open
inlineStyles plugin should not remove id attribute from target element#2066johnkenny54 wants to merge 3 commits intosvg:mainfrom
johnkenny54 wants to merge 3 commits intosvg:mainfrom
Conversation
Contributor
|
Wouldn't an option be better? Subsequent plugins do not have the context to clean up the |
Contributor
Author
|
Having an option isn't safe and just adds complexity to the plugin. If the id is no longer referenced, it should be removed by cleanupIds. Currently cleanupIds disables itself in the presence of |
folknor
added a commit
to folknor/svgo
that referenced
this pull request
Feb 18, 2026
- fix pretty + disabled short tags formatting svg#2088 - fix(removeOffCanvasPaths): invalid removal when line path starts with relative move svg#2086 - inlineStyles should not remove id attribute from target element svg#2066 - fix: cleanupIds changes style IDs incorrectly svg#2057 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed code that deletes id attribute from elements.
Resolves #2065.