feat(convertShapeToPath): Optionally convert rects with rounded corners to paths#1963
Open
feat(convertShapeToPath): Optionally convert rects with rounded corners to paths#1963
Conversation
Author
Special cases
|
Author
|
I've just found out there's already a similar PR (#1816), which I totally missed. Sorry for the dupe. 😅 |
baarde
added a commit
to baarde/lucide
that referenced
this pull request
May 3, 2024
Add a custom plugin to convert rectangles with rounded corners to paths. Hopefully, this may be removed when svg/svgo#1963 or another similar PR is merged in SVGO.
7 tasks
baarde
added a commit
to baarde/lucide
that referenced
this pull request
May 22, 2024
Add a custom plugin to convert rectangles with rounded corners to paths. Hopefully, this may be removed when svg/svgo#1963 or another similar PR is merged in SVGO.
Member
|
AFAIK, I wrote that plugin and excluded it just for the fact it makes paths longer than rects. Nothing to do with optimization. |
while the |
baarde
added a commit
to baarde/lucide
that referenced
this pull request
Jul 8, 2024
Add a custom plugin to convert rectangles with rounded corners to paths. Hopefully, this may be removed when svg/svgo#1963 or another similar PR is merged in SVGO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, rectangles with rounded corners are excluded from the
convertShapeToPathoptimization.This PR adds the conversion of rectangles with rounded corners to paths when the
convertArcsoption is enabled.Though the converted
<path>is quite longer than the source<rect>, the conversion is still useful to people who wish to merge all the shapes into a single path.