Unify SurrealDB benchmark target and endpoints, and fix sync mode#226
Merged
Unify SurrealDB benchmark target and endpoints, and fix sync mode#226
Conversation
Member
tobiemh
commented
Apr 18, 2026
tobiemh
commented
- Single SurrealDB endpoint implementation with docker/embedded/remote endpoint parsing
- Ensures durable transaction writes are correctly configurable. Previously SurrealDB was always using sync writes, even when disabled in the benchmarking script.
- Single SurrealDB DatabaseKind with server:/embedded/remote endpoint parsing - Trim database enum and simplify wiring in database.rs/main.rs - Align run.sh benchmark matrix and SurrealDB-related flags - Document unified usage in README - Update CI workflow for the new SurrealDB target/endpoints
The retry helper in the fulltext index cleanup path only matched the executor-level "The query was not executed due to a failed transaction" wrapper. For single-statement queries like REMOVE INDEX / REMOVE ANALYZER the raw kvs TransactionConflict error surfaces directly, so the retry never kicked in and the benchmark failed on transient RocksDB conflicts. Match on "This transaction can be retried" as well so both shapes are handled.
Re-enables the previously skipped SurrealDB + SurrealKV benchmark matrix entry, and lowers the per-benchmark thread count from 48 to 4 across the CI run matrix to better reflect available CI runner resources.
Inline CRUD_BENCH_SCANS alongside CRUD_BENCH_BATCHES so the CI exercises count/limit/offset scans plus indexed equality, range and fulltext conditions against every matrix database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.