Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

[WIP] Cythonize all the things!#167

Open
versae wants to merge 2 commits intomasterfrom
cythonize_all_the_things
Open

[WIP] Cythonize all the things!#167
versae wants to merge 2 commits intomasterfrom
cythonize_all_the_things

Conversation

@versae
Copy link
Copy Markdown
Collaborator

@versae versae commented Sep 20, 2017

No description provided.

Comment thread setup.py Outdated
ensure('numpy>=1.13.0')
ensure('Cython==0.26')
import numpy
from Cython.Build import cythonize
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module level import not at top of file

Comment thread setup.py Outdated

ensure('numpy>=1.13.0')
ensure('Cython==0.26')
import numpy
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module level import not at top of file

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 20, 2017

Codecov Report

Merging #167 into master will increase coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   98.04%   99.55%   +1.51%     
==========================================
  Files           4        3       -1     
  Lines         971      453     -518     
==========================================
- Hits          952      451     -501     
+ Misses         19        2      -17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd86f9...3dddb1d. Read the comment docs.

@versae versae force-pushed the cythonize_all_the_things branch from 2ce46a2 to ad163bc Compare September 20, 2017 18:33
@versae versae force-pushed the cythonize_all_the_things branch from ad163bc to 3dddb1d Compare September 20, 2017 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants