Grant id-token write for cosign OIDC signing - #4144
Conversation
Shipyard's release script now signs pushed images with cosign keyless (Sigstore OIDC), which requires id-token: write on the release workflow. Replace the empty permissions block with the minimal set: id-token: write for OIDC and contents: read for checkout. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
|
🤖 Created branch: z_pr4144/dfarrell07/glasswing-pr8-release-0.18 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. WalkthroughThe release workflow now grants ChangesRelease workflow permissions
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized workflow permission change is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Grants
id-token: writeon the release workflow so shipyard's cosign keyless signing (FIND-015) can mint a GitHub OIDC token from inside the Dapper container.Effective only after shipyard's FIND-015 change merges and the shipyard-dapper-base image is rebuilt/republished.
See commit messages for details.
Summary by CodeRabbit