Skip to content

Switch to depends-on/depends-on-action for PR dependencies - #4063

Merged
tpantelis merged 2 commits into
submariner-io:develfrom
tpantelis:switch-to-depends-on-action
Jun 5, 2026
Merged

Switch to depends-on/depends-on-action for PR dependencies#4063
tpantelis merged 2 commits into
submariner-io:develfrom
tpantelis:switch-to-depends-on-action

Conversation

@tpantelis

@tpantelis tpantelis commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Replace unmaintained dependent-issues with depends-on-action

The old action (z0al/dependent-issues) is archived and will stop working when GitHub removes Node.js 20 support on September 16, 2026.

The new action (depends-on/depends-on-action) is actively maintained - it currently uses Node.js 20 but there's an open PR to upgrade..

Differences with dependent-issues:

Fixes: #2836

Summary by CodeRabbit

  • Chores
    • Updated internal pull-request dependency workflow: now runs only on pull request events, uses reduced permissions, and streamlines dependency checks.
    • Improved detection of dependent and unmerged pull requests to provide more accurate dependency status.

Replace unmaintained dependent-issues with depends-on-action

The old action (z0al/dependent-issues) is archived and will stop working
when GitHub removes Node.js 20 support on September 16, 2026.

The new action (depends-on/depends-on-action) is actively maintained -
it currently uses Node.js 20 but there's an open PR to upgrade..

Differences with dependent-issues:
- Syntax change: Use "Depends-On: submariner-io#123" instead of "depends on submariner-io#123"
- Issues no longer supported (PRs only)
- Removed schedule trigger (not applicable with new action)

Fixes: submariner-io#2836

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot

Copy link
Copy Markdown
Contributor

🤖 Created branch: z_pr4063/tpantelis/switch-to-depends-on-action
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR/issue depends on:

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1fb6038-4a20-4c46-8f30-c687a88e1fc9

📥 Commits

Reviewing files that changed from the base of the PR and between 046bb11 and 9ebd2b7.

📒 Files selected for processing (1)
  • .github/workflows/dependent-issues.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/dependent-issues.yml

Walkthrough

This PR narrows the workflow trigger to pull_request_target events, reduces job permissions to pull-requests: write, and replaces the archived z0al/dependent-issues action with depends-on/depends-on-action@0.16.0 using token-based configuration and enabled unmerged-PR checks.

Changes

PR dependency check workflow migration

Layer / File(s) Summary
Migrate dependency check to new action with updated triggers
.github/workflows/dependent-issues.yml
Event triggers narrowed to PR-only (pull_request_target) with specific PR event types and permissions limited to pull-requests: write. The dependency-check step replaces the archived z0al/dependent-issues action with depends-on/depends-on-action@0.16.0, configured via with.token: ${{ secrets.GITHUB_TOKEN }} and check-unmerged-pr: true.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

dependencies, ready-to-test, github_actions

Suggested reviewers

  • mkolesnik
  • Oats87
  • skitt
  • sridhargaddam
  • vthapar
  • yboaron
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: switching from z0al/dependent-issues to depends-on/depends-on-action for managing PR dependencies.
Linked Issues check ✅ Passed The PR addresses issue #2836 by replacing the archived z0al/dependent-issues action with depends-on/depends-on-action, which is actively maintained and resolves the archived action dependency issue.
Out of Scope Changes check ✅ Passed All changes in the workflow file are directly related to switching the dependency-checking action and are within the scope of issue #2836; no unrelated modifications detected.
Actionable Comments Resolved ✅ Passed No unresolved actionable comments found; all PR objectives addressed and workflow successfully migrated from z0al/dependent-issues to depends-on/depends-on-action with commit SHA pinning.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/dependent-issues.yml:
- Around line 21-24: Replace the mutable tag reference
depends-on/depends-on-action@0.16.0 with the action pinned to the commit SHA by
updating the uses value to
depends-on/depends-on-action@e7915c70317af4efc4e6c4a4eb1e9260e215270c so the
workflow is pinned to an immutable commit; locate the uses entry for
depends-on/depends-on-action in the workflow and swap the tag for the provided
SHA.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0345df4-d96c-4cb9-84ca-4c6c484e6063

📥 Commits

Reviewing files that changed from the base of the PR and between e0f3c85 and 046bb11.

📒 Files selected for processing (1)
  • .github/workflows/dependent-issues.yml

Comment thread .github/workflows/dependent-issues.yml Outdated
Pin the action reference to the immutable commit SHA
e7915c70317af4efc4e6c4a4eb1e9260e215270c instead of the
mutable tag v0.16.0 to prevent supply chain attacks.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 5, 2026
@tpantelis
tpantelis merged commit a05e1e3 into submariner-io:devel Jun 5, 2026
55 of 56 checks passed
@submariner-bot

Copy link
Copy Markdown
Contributor

🤖 Closed branches: [z_pr4063/tpantelis/switch-to-depends-on-action]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-test When a PR is ready for full E2E testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider replacing dependent-issues

3 participants