Adds shared OtherString type alias to better annotate non-exhaustive enums#2786
Open
jar-stripe wants to merge 2 commits into
Open
Adds shared OtherString type alias to better annotate non-exhaustive enums#2786jar-stripe wants to merge 2 commits into
jar-stripe wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a shared OtherString type alias to be used in generated/public TypeScript types when representing “open” (non-exhaustive) string-union enums.
Changes:
- Introduces
OtherStringtype alias insrc/shared.tsfor use at the end of open string unions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
xavdid
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We want to better support "open" enums in our SDKs to make it more clear to users which enums should be handled exhaustively and which should not. Open enums can have values added in non-breaking (minor) releases.
What?
See Also
Changelog