ACM-21338 FleetResourceEventStream#4750
Merged
openshift-merge-bot[bot] merged 24 commits intostolostron:mainfrom Aug 1, 2025
Merged
ACM-21338 FleetResourceEventStream#4750openshift-merge-bot[bot] merged 24 commits intostolostron:mainfrom
openshift-merge-bot[bot] merged 24 commits intostolostron:mainfrom
Conversation
KevinFCormier
requested changes
Jul 14, 2025
Contributor
KevinFCormier
left a comment
There was a problem hiding this comment.
Hey Vishali,
I left a few inline comments. In addition:
- It would be great if you could move the component directly under
src/componentsand then move thesrc/components/FleetResourceEventStreamfolder undersrc/internal... I'm trying to have a flat structure undersrc/apiandsrc/componentshaving 1 file per exported API. - I had asked you to incorporate some recent updates from Ugo into your work. See #4746 (comment)
- It looks like the event stream is not actually working (and it wasn't before your changes either). Can you investigate this and try to resolve?
cc08dac to
eb3ab92
Compare
eb3ab92 to
f6bf697
Compare
a42b699 to
9cb7645
Compare
a1df9a4 to
6c18c21
Compare
0dbe889 to
b8ea1aa
Compare
Contributor
Author
|
/retest |
b8ea1aa to
74ce144
Compare
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
…ebSocket improvements Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
1e5a1eb to
6058126
Compare
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, vishsanghishetty The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test unit-tests-sonarcloud |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📝 Summary
Ticket Summary (Title):
Add FleetResourceEventStream component for multicluster event streaming
Overview
This PR introduces a multicluster-aware version of the ResourceEventStream component. Instead of only showing events from the hub cluster, it can now display real-time Kubernetes events for resources running on any managed cluster in your fleet.
The component intelligently falls back to the standard OpenShift console ResourceEventStream when viewing hub cluster resources, so existing functionality remains unchanged while adding new multicluster capabilities..
Key Features
involvedObject.uid,involvedObject.name, andinvolvedObject.kindTechnical Implementation
FleetK8sResourceCommontype which extendsK8sResourceCommonwith optionalclusterpropertyfleetWatch,useFleetK8sAPIPath,useHubClusterName)Ticket Link:
https://issues.redhat.com/browse/ACM-21338
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers