feat: Add VITE_HOST env var for instance PR - #292
Open
Pecacheu wants to merge 2 commits into
Open
Conversation
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required change for when stoatchat/for-web#1315 is merged.
New VITE_HOST environment var for web takes the place of all the other individual configuration URLs (VITE_WS_URL, VITE_MEDIA_URL, etc.) that will now be pulled from the backend. Well, technically the existing VITE_API_URL var takes the place of them, the VITE_HOST is necessary because the API could exist at a nonstandard path relative to the frontend domain, though it is almost always
https://domain.com/api, we don't want to assume this with no way to override it.