fix: prevent duplicate replies and enforce max 5 reply targets - #110
Closed
gabrielfordevelopment wants to merge 1 commit into
Closed
fix: prevent duplicate replies and enforce max 5 reply targets#110gabrielfordevelopment wants to merge 1 commit into
gabrielfordevelopment wants to merge 1 commit into
Conversation
Signed-off-by: Gabriel <60961939+gabrielfordevelopment@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #57
Note
Previously, reply targets could be added through multiple code paths (e.g. draft and send callbacks), but the max-5 / duplicate validation was not consistently applied in all of them.
This change routes all reply additions through
addReplyTo(...), so duplicate prevention, max-5 enforcement, and mention handling are always applied the same way.Fixed: Can't reply to the same message multiple times + max 5 reply at once. (See the bug at #57 )
replyfix.mp4