Wire up numNodes config setting to mission CoreSet creation#372
Draft
Wire up numNodes config setting to mission CoreSet creation#372
Conversation
The numNodes CLI option (--num-nodes) was accepted but never used. This change passes context.numNodes to the nodeCount field of CoreSetOptions in all missions that previously relied on the default nodeCount from CoreSetOptions.GetDefault (which is 3). The default value of --num-nodes is also changed from 5 to 3 to preserve backward compatibility with the existing default behavior. Missions that explicitly set their own nodeCount (e.g., catchup missions with nodeCount=1, or complex topology missions) are not affected by this change. Agent-Logs-Url: https://github.com/stellar/supercluster/sessions/f7085b35-0735-4239-983a-8e7463664eac Co-authored-by: marta-lokhova <9428003+marta-lokhova@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused numNodes config setting
Wire up numNodes config setting to mission CoreSet creation
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numNodes(--num-nodes) was accepted as a CLI option but never read fromMissionContext, so passing it had no effect.Changes
11 mission files: Set
nodeCount = context.numNodesonCoreSetOptionsfor missions that previously inherited the hardcoded default of 3 fromCoreSetOptions.GetDefault:MissionBootAndSync,MissionSimplePayment,MissionLoadGeneration,MissionLoadGenerationWithSpikes,MissionLoadGenerationWithTxSetLimit,MissionSorobanInvokeHostLoad,MissionSorobanLoadGeneration,MissionUpgradeTxClusters,MissionProtocolUpgradeWithLoad,MissionValidatorSetup,MissionDatabaseInplaceUpgrade(core set only)CLI default: Changed
--num-nodesdefault from5to3to match the existingCoreSetOptions.GetDefaultnodeCount, preserving current behavior when the flag is omitted.Missions that explicitly set their own
nodeCount(catchup, complex topology, mixed-image, etc.) are unchanged.