Skip to content

Wire up numNodes config setting to mission CoreSet creation#372

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/remove-unused-numnodes-setting
Draft

Wire up numNodes config setting to mission CoreSet creation#372
Copilot wants to merge 2 commits intomainfrom
copilot/remove-unused-numnodes-setting

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

numNodes (--num-nodes) was accepted as a CLI option but never read from MissionContext, so passing it had no effect.

Changes

  • 11 mission files: Set nodeCount = context.numNodes on CoreSetOptions for missions that previously inherited the hardcoded default of 3 from CoreSetOptions.GetDefault:

    • MissionBootAndSync, MissionSimplePayment, MissionLoadGeneration, MissionLoadGenerationWithSpikes, MissionLoadGenerationWithTxSetLimit, MissionSorobanInvokeHostLoad, MissionSorobanLoadGeneration, MissionUpgradeTxClusters, MissionProtocolUpgradeWithLoad, MissionValidatorSetup, MissionDatabaseInplaceUpgrade (core set only)
  • CLI default: Changed --num-nodes default from 5 to 3 to match the existing CoreSetOptions.GetDefault nodeCount, preserving current behavior when the flag is omitted.

Missions that explicitly set their own nodeCount (catchup, complex topology, mixed-image, etc.) are unchanged.

// Before: numNodes ignored, always 3
MakeLiveCoreSet "core" (CoreSetOptions.GetDefault context.image)

// After: respects --num-nodes
MakeLiveCoreSet "core"
    { CoreSetOptions.GetDefault context.image with
          nodeCount = context.numNodes }

The numNodes CLI option (--num-nodes) was accepted but never used.
This change passes context.numNodes to the nodeCount field of
CoreSetOptions in all missions that previously relied on the
default nodeCount from CoreSetOptions.GetDefault (which is 3).

The default value of --num-nodes is also changed from 5 to 3 to
preserve backward compatibility with the existing default behavior.

Missions that explicitly set their own nodeCount (e.g., catchup
missions with nodeCount=1, or complex topology missions) are not
affected by this change.

Agent-Logs-Url: https://github.com/stellar/supercluster/sessions/f7085b35-0735-4239-983a-8e7463664eac

Co-authored-by: marta-lokhova <9428003+marta-lokhova@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused numNodes config setting Wire up numNodes config setting to mission CoreSet creation Apr 16, 2026
Copilot AI requested a review from marta-lokhova April 16, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numNodes config setting is not used

2 participants